Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 20 forks source link

Refactor discover function #184

Open Bouni opened 1 month ago

Bouni commented 1 month ago

As brought up in #73 the discover function was to large and cased ruff warnings.

This PR splits the discover function into smaller logical functions and adds unit tests

github-actions[bot] commented 1 month ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py1841194%42–43, 46–51, 257–258, 263
   __main__.py21210%3–49
   datatypes.py276199%82
   discover.py58198%62
luxtronik/scripts
   dump_changes.py43430%7–85
   dump_luxtronik.py26260%6–52
TOTAL69410385% 

Tests Skipped Failures Errors Time
134 0 :zzz: 0 :x: 0 :fire: 4.196s :stopwatch: