Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 20 forks source link

Add black in RO mode to lint GH action #82

Closed Bouni closed 1 year ago

Bouni commented 1 year ago

As discussed in #77 I've added black to the lint CI job.

Info: https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#writeback-and-reporting

Bouni commented 1 year ago

@kbabioch Is there a reason for installying pytest within the pylint job?: https://github.com/Bouni/python-luxtronik/blob/00b3ee8dedade655d8b349b371ee4ab164c5ebd3/.github/workflows/lint.yml#L59-L60

kbabioch commented 1 year ago

@kbabioch Is there a reason for installying pytest within the pylint job?:

https://github.com/Bouni/python-luxtronik/blob/00b3ee8dedade655d8b349b371ee4ab164c5ebd3/.github/workflows/lint.yml#L59-L60

Without it, pylint would complain about an import error, see: 8dfeffb90b19a24c5a13a0476de359338e19730c

We could also try to maintain some kine of requirements.txt or re-use pyproject.toml and install dependencies via pip.

Bouni commented 1 year ago

@kbabioch Do you know, is there a way to run actions just once and not for push and pull_request on every commit?

kbabioch commented 1 year ago

@kbabioch Do you know, is there a way to run actions just once and not for push and pull_request on every commit?

No, unfortunately that seems to be not totally trivial. Had looked into this some weeks ago, but couldn't figure it out quickly.