search

Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 20 forks source link

Basic CLI #83

Closed Bouni closed 1 year ago

Bouni commented 1 year ago

I changed moved the scripts folder into the luxtronik folder and added a __init__.py so that it is a module. Then I refactored the dump script slightly that it can be called diectly python luxtronik/scripts/dump.py 192.168.178.1 8889 or as a script defined in pyproject.toml luxtronik dump 192.168.178.1 8889

Bouni commented 1 year ago

:expressionless: so pylint doesn't like the identical argparse section in two files ...

Bouni commented 1 year ago

See #53 and #59

discovery

luxtronik discover

dump

luxtronik dump <ip> <port>

or

python luxtronik/scripts/dump.py <ip> <port>

kbabioch commented 1 year ago

@Bouni Could you rebase this on top of current main? There seem to be some conflicts, and there is an additional script that has been added in the mean time (dump-changes.py) that should be migrated also.

Bouni commented 1 year ago

Yes but only tomorrow, just have a phone with me right now

kbabioch commented 1 year ago

Yes but only tomorrow, just have a phone with me right now

No worries. We were able to reduce the amount of open PRs and issues quite a bit today, let's continue this trend in the upcoming days, so we'll get some traction here again ;-).

kbabioch commented 1 year ago

Overall the changes look very promising. Suggested some minor adjustments to the documentation. Can be merged afterwards from my point of view.