Closed Guzz-T closed 1 year ago
Change itself looks fine, would like to have a more detailed description in the pull request / commit, though.
The issue linked above should contain all relevant information. I don't know what else to write about it other than copying the description here :)
I've edited the title and description with some details. You're right of course, that #89 already contains all relevant information. However I would like to have the most basic stuff also added to the commit and merge itself, because this is what will end up in the Git repository. When running git blame
later on while trying to debug a problem, no one is willing to cross-reference every line of code with some GitHub issues :-).
So, redundancy (e.g. copy & paste) is needed in some places sometimes ;-).
As demonstrated in #89 the value 19 for the SwitchoffFile datatype represents
PV max
.This change adds the entry accordingly to make the mapping available for consumers of the datatype module.
Fixes #89.