search

Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 20 forks source link

Add mapping for PV max to SwitchoffFile datatype #90

Closed Guzz-T closed 1 year ago

Guzz-T commented 1 year ago

As demonstrated in #89 the value 19 for the SwitchoffFile datatype represents PV max.

This change adds the entry accordingly to make the mapping available for consumers of the datatype module.

Fixes #89.

kbabioch commented 1 year ago

Change itself looks fine, would like to have a more detailed description in the pull request / commit, though.

Guzz-T commented 1 year ago

The issue linked above should contain all relevant information. I don't know what else to write about it other than copying the description here :)

kbabioch commented 1 year ago

I've edited the title and description with some details. You're right of course, that #89 already contains all relevant information. However I would like to have the most basic stuff also added to the commit and merge itself, because this is what will end up in the Git repository. When running git blame later on while trying to debug a problem, no one is willing to cross-reference every line of code with some GitHub issues :-).

So, redundancy (e.g. copy & paste) is needed in some places sometimes ;-).