search

Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 20 forks source link

issue-49: Convert some datatype functions into class methods #96

Closed Guzz-T closed 1 year ago

Guzz-T commented 1 year ago

As discussed in #49 the implementation of the functions Base.to_heatpump, Base.from_heatpump and SelectionBase.options are correspond to class methods. But are not yet offered as such. This pull-request transform them into class-methods.

kbabioch commented 1 year ago

For now we don't seem to have agreed on an overall architecture, so I'm not entirely sure what "the best" way to handle those methods is. I'm fine with the change, maybe will have to re-factor it in the future further.