Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 20 forks source link

Following the README leads to an error #98

Closed haarts closed 1 year ago

haarts commented 1 year ago

I've diligently followed the README and did a pip install luxtronik. That installed the latest version 0.3.14. Then I opened a Python REPL and was greeted with an TypeError: cannot unpack non-iterable NoneType object error. The read() method on the l object returned nothing. The error makes sense.

On closer inspection, the code I installed with pip lagged far behind the code in main! Resulting in this unfortunate error.

Perhaps it is a good idea to release a new version aligning what people install with the README?

Bouni commented 1 year ago

You're right, but we don't want to release a new version at the moment because there are more breaking changes to come whcih we want to bundle in a 0.4 version or something like that.

I guess we should have dev branch and keep the main branch equal to the latest release 🤔

Bouni commented 1 year ago

In the meanwhile you can follow the instructions here:

https://github.com/Bouni/python-luxtronik/tree/0.3.14

Or if you prefer the dev version, install it directly from git:

pip install 'luxtronik@git+https://github.com/Bouni/python-luxtronik.git#main'

kbabioch commented 1 year ago

From my point of view there is not much we can do. The README file of main will never match any specific version that was released on PyPI. @Bouni pointed you to the corresponding README file.

As said we're working (unfortunately not actively enough) on some major changes to the datatypes, etc., hence I would suggest to close this issue. Feel free to re-open when there is more to discuss.