search

Bounties-Network / BountiesFactory

A front-end explorer for the StandardBounty contracts
MIT License
19 stars 12 forks source link

bug: mainnet bounty shows wrong text when logged on rinkerby #15

Open thelostone-mc opened 6 years ago

thelostone-mc commented 6 years ago

Issue

Mainnet bounty shows wrong text when logged on rinkerby network via metmask

screen shot 2018-05-24 at 5 26 28 pm

Steps to Reproduce

Login into the test net (rinkerby) via metamask and open a bounty funded on the mainnet like https://beta.bounties.network/bounty/v1/486

Fix

Update the content to use the current active network rather than hardcoding the message

thelostone-mc commented 6 years ago

@villanuevawill opened up the issue here ! Sorry about that

villanuevawill commented 2 hours ago @thelostone-mc - 485 and 487 show up. This is a pretty extreme edge case where 486 does not exist on the rinkeby testnet. Most ids will exist from the mainnet that exist on rinkeby. We should def. update this, but I think there are only 3 ids that don't exist in rinkeby that exist in mainnet.

mbeylin commented 6 years ago

Basically the way the Bounties Network operates is that we use whichever Ethereum network gets injected by MetaMask, whether it's MainNet or Rinkeby. A fix for this could entail us embedding the network type directly in the URL, but this would likely break our existing URL structure.

I will push a fix which changes the error message depending on the current network.