BourbonWarfare / POTATO

GNU General Public License v2.0
18 stars 28 forks source link

fix weapon lowering while walking weird animation #500

Closed kil0byt3 closed 1 month ago

kil0byt3 commented 5 months ago

(current) when you lower your weapon with double ctrl, you'll be locked into moving in the direction you were traveling for a few seconds, even if you stop giving movement inputs.

(when fix is applied) when you lower your weapon with double ctrl, and if you stop giving movement inputs, you'll stop moving within half of a second

(limitations): if you continue giving movement inputs, you'll keep moving as if the fix was not applied. I don't know if there's anything that can be done about this

(intent) make movement feel a bit more responsive. It takes a bit of getting used to removing your hand from the keyboard to stop, but it works a lot better than the current system in which you can't stop moving once the animation is playing

if you want to test it yourself you can uncomment the two systemChat lines and it'll print when it applies

kil0byt3 commented 2 months ago

tested, this works,

(current) when you lower your weapon with double ctrl, you'll be locked into moving in the direction you were traveling for a few seconds, even if you stop giving movement inputs.

(when fix is applied) when you lower your weapon with double ctrl, and if you stop giving movement inputs, you'll stop moving within half of a second

(limitations): if you continue giving movement inputs, you'll keep moving as if the fix was not applied. I don't know if there's anything that can be done about this

(intent) make movement feel a bit more responsive. It takes a bit of getting used to removing your hand from the keyboard to stop, but it works a lot better than the current system in which you can't stop moving once the animation is playing

if you want to test it yourself you can uncomment the two systemChat lines and it'll print when it applies

added the above summary to the PR and marked as ready for review