this is the best pull request ever

BowdoinOrient / bonus

Bowdoin Orient Network Update System v2, the bowdoinorient.com frontend and backend since August 2012.

http://bowdoinorient.com/

Other

3 stars 2 forks source link

this is the best pull request ever #82

Closed bjacobel closed 11 years ago

bjacobel commented 11 years ago

Took me five minutes and thirteen characters to fix #33 and speed up our mobile page load by... 30%? 50%? Who the fuck knows.

Also I just discovered github emoji. :+1: :poop: :poop: :poop: :shipit:

tophtucker commented 11 years ago

hahaha. when i added isMobile() i honestly don't know why i stopped just short of doing this.

tophtucker commented 11 years ago

"with just a little cleverness here," i wrote. dumb. anyway, nice.

bjacobel commented 11 years ago

Part of the reason it was so easy was the article block refactoring I did at the end of last year. Otherwise it would have been a change to ten files or so instead of the one. Testing I just did on desktop spoofing a mobile useragent says the page asset load is about 30% faster over ethernet. no idea how much faster it'd be over 3G... a lot, probably. SHIP IT! :shipit: