search

Bowen7 / regex-vis

🎨 Regex visualizer & editor
https://regex-vis.com
MIT License
3.73k stars 275 forks source link

Can't figure out how to delete a node #65

Open MarqueIV opened 1 year ago

MarqueIV commented 1 year ago

I love this editor. Very easy to add/modify things you've added, but for the life of me, I can't figure out how to delete what I have selected. A simple enhancement would be to select the text in the editor textbook representing what you have selected in the diagram. You could then simply press delete.

For that same reason, the editor text box and the regex text viewer over on the right info pane seem a little redundant, with the one on the right highlighting but not being editable, and the one on the bottom being editable but not highlighting. If you combined the functionality into a single editor (at the bottom) and added the highlighting like I suggested, then that would go a long way to being even more usable.

Speaking of that box down at the bottom, can you please make it resizable? Personally Id' love it to be full-width, but I get visually it's not as appealing. So give us drag handles to make it so you can drag them out. (Currently I'm planning on attacking this with CSS injection, but that's a hack.)

MarqueIV commented 1 year ago

Aaah... more experimentation shows you can use the backspace key. That said, it would be helpful to make the delete key (also known as the forward-delete key) also respond as that's a dedicated 'Delete' button on full-sized keyboards.

Additionally, please consider adding a 'Delete' button in the editor. I'd recommend up near the add buttons (since it's the opposite, but related), or all the way down at the bottom. It's nice to be able to just click around for the initial setup, then use the keyboard to refine things later.

Bowen7 commented 1 year ago

Thanks for your advice!

Aaah... more experimentation shows you can use the backspace key. That said, it would be helpful to make the delete key (also known as the forward-delete key) also respond as that's a dedicated 'Delete' button on full-sized keyboards.

I have created a pull request to support using the "Delete" button to delete a node.

For that same reason, the editor text box and the regex text viewer over on the right info pane seem a little redundant, with the one on the right highlighting but not being editable, and the one on the bottom being editable but not highlighting. If you combined the functionality into a single editor (at the bottom) and added the highlighting like I suggested, then that would go a long way to being even more usable.

This will make the user think they can select nodes in the graphics by selecting text in the input? I am not sure...

Speaking of that box down at the bottom, can you please make it resizable? Personally Id' love it to be full-width, but I get visually it's not as appealing. So give us drag handles to make it so you can drag them out. (Currently I'm planning on attacking this with CSS injection, but that's a hack.)

If you make it resizable and want to make it wider, the right panel will not have enough width to show the full content.

Additionally, please consider adding a 'Delete' button in the editor. I'd recommend up near the add buttons (since it's the opposite, but related), or all the way down at the bottom. It's nice to be able to just click around for the initial setup, then use the keyboard to refine things later.

I will consider where to place it.

BTW, do you find the icons for the buttons under the Edit tab of the right pane confusing? They may not effectively convey their meaning, so I plan to modify them.

Please feel free to discuss these with me