search

BowlerHatLLC / asconfigc

Command line utility that builds ActionScript projects configured with an asconfig.json file.
https://www.npmjs.com/package/asconfigc
Apache License 2.0
18 stars 5 forks source link

Outputting extra line returns #13

Closed Harbs closed 7 years ago

Harbs commented 7 years ago

When running asconfigc, I'm seeing a lot of extra line returns which causes the results to scroll up off the screen. https://github.com/BowlerHatLLC/vscode-nextgenas/issues/109

Harbs commented 7 years ago

Could this be it? https://github.com/BowlerHatLLC/asconfigc/blob/9b4d3b9b31233529e1d47a8b56becab18043da39/src/com/nextgenactionscript/asconfigc/utils/assetPathToOutputPath.as#L46

joshtynjala commented 7 years ago

Good catch! That's probably it. I had noticed some extra lines recently too, and I assumed it was just some weird quirk of VSCode's Terminal panel. I'll bet that VSCode was stripping those extra lines when they were displayed in the Output panel (so we didn't notice), but it doesn't strip them in the Terminal panel.

joshtynjala commented 7 years ago

This issue is fixed in today's v0.5.2 update to asconfigc.

Harbs commented 7 years ago

Installed and tested. Perfect! :heart:

Harbs commented 7 years ago

(BTW, I don't see a commit to the above file. Was it that or something else?)

joshtynjala commented 7 years ago

That was it! I just forgot to push the master branch.