search

BoxFactura / pulltorefresh.js

A quick and powerful plugin for your pull-to-refresh needs in your webapp.
http://bxf.mx/pulltorefresh.js/
MIT License
3.97k stars 278 forks source link

can not scroll in chrome 74 or highter #80

Closed gdutwyg closed 5 years ago

gdutwyg commented 5 years ago

Bug report

Current behavior: in the chorme 74,the page I can slide down, but i can't slide up. And it is normal if i use chrome 66 or lower Expected behavior: the page can slide down or slide up JSFiddle URL for demo with bug: https://jsbin.com/wisiligeke/1/edit?html,js,console,output Browsers affected: mobile chorme 74

faelsoto commented 5 years ago

@pateketrueke it's the issue we were talking about last week.

@gdutwyg we're looking into it, a quick fix would be to add a new parameter:

shouldPullToRefresh(){
   return !window.location.top;
}
gdutwyg commented 5 years ago

@faelsoto oh，it seems that the code can not fix it， and i add the code，also it is not normal in chorme 66.

faelsoto commented 5 years ago

I'm sorry, I made up that property, don't know what I was thinking.

The fix as we have it in production is this:

shouldPullToRefresh(){
   !window.scrollY;
}
gdutwyg commented 5 years ago

ok, it works. i hope you can fix it in next version, thanks.

faelsoto commented 5 years ago

It's fixed, please download v0.1.19

crusy commented 5 years ago

It's fixed, please download v0.1.19

It's not on npm yet, or is it? For the records: 0.1.19 includes PR #81, right? It's kind of confusing, because this issue is #80 :wink:

pateketrueke commented 5 years ago

Hi @crusy please pull v0.1.19 from NPM, it's published now.

And yeah, v0.1.19 includes both PRs.