BoxOfDevs / boxofdevs.github.io

The BoxOfDevs website
https://boxofdevs.github.io/
Other
4 stars 4 forks source link

Fixed Picture Postion #33

Closed Jean-TKG closed 4 years ago

Jean-TKG commented 4 years ago

A preview of the fixed pics https://theknightgamerz.github.io/boxofdevstest.github.io/

ghost commented 4 years ago

I just added this " and it changes the position of lower part of the website

Can you provide screenshots and the browser you are using?

SyntaxDragon commented 4 years ago

maybe we should move this to discord for better communication and ease?

ghost commented 4 years ago

maybe we should move this to discord for better communication and ease?

I'd rather keep a public record on GitHub. Not everyone interested in BoxOfDevs has access to Discord.

ghost commented 4 years ago

from Discord:

Screen Shot 2019-12-09 at 3 52 53 PM Screen Shot 2019-12-09 at 3 52 48 PM
ghost commented 4 years ago

It looks like this is an issue with mobile browsers. Rather than changing the formatting of the file, it would make more sense to change the CSS and leave a comment.

HimbeersaftLP commented 4 years ago

@nathfreder if you look at the second line that changed, you see that he fixed a spelling mistake (missing quote), the first line is just a cosmetic code change.

ghost commented 4 years ago

Sorry, at first glance I thought they were the same.