search

BoxyUwU / rust-quiz

28 stars 5 forks source link

Make safety comment less incorrect #12

Closed HayleyDeckers closed 5 months ago

HayleyDeckers commented 5 months ago

There was some debate at RustNL about this comment saying u32 when it should be u8. Since we couldn't reach a consensus as to whether it should be u32 or u8 I propose we change it to u16 as a compromise and to resolve this blocker in favor of making progress on this key issue.

WaffleLapkin commented 5 months ago

No

HayleyDeckers commented 5 months ago

yes

BoxyUwU commented 5 months ago

I think waffle is stepping a bit outside of its purrview

BoxyUwU commented 5 months ago

Thank you for your hard work Hayley

WaffleLapkin commented 5 months ago

okay I should actually have read the pr description it's funny lmao

Noratrieb commented 5 months ago

wow waffle

WaffleLapkin commented 5 months ago

Interestingly, since this changes both comments they are more incorrect (both comments now refer to incorrect types, on top of being just blatantly wrong about safety).