BoyC / GW2TacO

Guild Wars 2 Tactical Overlay (GW2TacO)
Other
245 stars 48 forks source link

MarkerPacks.json downloadurl inconsistencies. #132

Closed nate998877 closed 1 year ago

nate998877 commented 1 year ago

I would like it if there was some consistency in the URLs of packs in MarkerPacks.json that are hosted on GitHub.

As an example, these three packs are referenced in three different ways - https://github.com/xrandox/TehsTrails/raw/main/TehsTrails/TehsTrails.taco - Raw reference to repo https://github.com/Kresky/gw2-blish-markers/releases/download/%s/kreskysmarkers.zip - String substitution w/ Version number https://github.com/Girbilcannon/Pewpews-Power-Paths/releases/latest/download/Pewpews_Power_Paths.taco - Latest release

I understand not everyone may have the technical ability to provide releases for their packs. However, every pack I've checked so far includes them. This means they can be referenced via the latest release format.

Eg. https://github.com/xrandox/TehsTrails/releases/latest/download/TehsTrails.taco https://github.com/Kresky/gw2-blish-markers/releases/latest/download/kreskysmarkers.zip

I'm happy to make a PR for this if others are interested.

nate998877 commented 1 year ago

Thanks!