search

BoyC / GW2TacO

Guild Wars 2 Tactical Overlay (GW2TacO)
Other
248 stars 45 forks source link

MouseHighlight wonders away on Left Button camera movement #69

Open JxMills opened 2 years ago

JxMills commented 2 years ago

MouseHighlight runs amuck when the left button is held to rotate camera, the position isn't being held / the reticle moves across the screen away from target. Works fine with Right click in turning, and for both keys for movement, but just rotating the camera using the left button causes the highlight to rotate away, then jerks back on release.

Looking at the code, it appears to be MouseHighlight.cpp , line 47, only checks for the right button being held. if ( ( GetKeyState( VK_RBUTTON ) & 0x100 ) != 0 )

Was thinking VK_LBUTTON should've also been included to correct the wondering highlight, possibly: if ( (( GetKeyState( VK_LBUTTON ) & 0x100 ) != 0 ) || (( GetKeyState( VK_RBUTTON ) & 0x100 ) != 0 ) )

Not sure if this was deliberately excluded due to some other use case... In wvw it gets really confusing with the real target vs mousehighlight being in 2 seperate places.

I don't have a Visual Studio Environment setup to try a build, so figured probably faster to report it here.

BoyC commented 2 years ago

The issue here is that implementing this would affect inventory management and I'd like to avoid that