BoyCook / TwitterJSClient

Twitter client written in JavaScript packaged as a node module
GNU General Public License v2.0
562 stars 176 forks source link

pls correct readme because twitter_config not work #66

Open odykyi opened 6 years ago

odykyi commented 6 years ago

Where I need to create this config? I try create twitter_config file in root and in data directory its not work

/node_modules/twitter-node-client/lib/Twitter.js:9
    this.consumerKey = config.consumerKey;
                             ^

TypeError: Cannot read property 'consumerKey' of undefined
{
        "consumerKey": "XXX",
        "consumerSecret": "XXX",
        "accessToken": "XXX",
        "accessTokenSecret": "XXX",
        "callBackUrl": "XXX"
}

Please create example folder in your repository with example twitter application

davidvexel commented 6 years ago

It works when you pass your consumer key and access token as process envs, like this:

twitterConsumerKey=<example> twitterConsumerSecret=<example> twitterAccessToken=<example> twitterAccessTokenSecret=<example> node index.js

odykyi commented 6 years ago

ok pls add this to readme twitterConsumerKey=<example> twitterConsumerSecret=<example> twitterAccessToken=<example> twitterAccessTokenSecret=<example> node index.js

davidvexel commented 6 years ago

@odykyi it just worked for me, I'm not the developer of this plugin.

chiemekailo commented 5 years ago

I know this is an old thread, but I still wanted to chip in on Craig's earlier guide...

While environment variables are okay, you only need to read the _twitterconfig file as string, and then JSON.parse it into the function as an object. Here's how I did it..

var fs = require('fs'); fs.readFile('data/twitter_config', 'utf8', function(err, contents) { var twitter = new Twitter(JSON.parse(contents)); });

Works fine.

odykyi commented 5 years ago

@chiemekailo could you pls create PR and update readme with yours example thanks