search

BoyuanJiang / matching-networks-pytorch

Matching Networks for one shot learning
228 stars 67 forks source link

Seems fce are not correctly used #1

Open suruoxi opened 6 years ago

suruoxi commented 6 years ago

In the forward function of matching_net.py, output of self.g is passed to self.lstm, but the output of self.lstm is not used.

Note the 'output' becomes 'outputs' in 'outputs = self.lstm(output)'

code line 198

        # use fce?
        if self.fce:
            outputs = self.lstm(output)

        # get similarities between support set embeddings and target
        similarites = self.dn(support_set=output[:-1], input_image=output[-1])
MarioProjects commented 5 years ago

Do you suggest then change outputs to output?