Theme guidelines

[MiguelCastillo]

In the spirit to keep things consistent across themes, I think we could use a checklist before publishing a theme. So, the checklist isn't really to get all "use strict" on anyone, but more to help our friends using our themes have confidence that we release good and consistent themes. I predict that there will be lots of themes in the registry so its important to make sure ours are top notch. ;-)

Let's start here :)

• [ ] Repository names should be camel case that starts with a capital. http://en.wikipedia.org/wiki/CamelCase. This does not mean that themes can only be letter; it's just the casing of the words. So you can have your Sweet80s, but not sweet-80s or sweet_80sThemeForBrackets.
• [ ] Update the themes.json in brackets-themes.github.io to include a screenshot when adding new themes.
• [ ] package.json needs to be consistent with requirements here.
• [ ] Dark themes need to have the dark flag in package.json.
• [ ] Verify that text in HTML files is visible when selecting a matching tag.

This guideline can also be applicable when someone wants to publish their theme with us.

Any thoughts?

[larz0]

Make sure OVR cursor is visible?

[MiguelCastillo]

Good point @larz0

[MiguelCastillo]

I haven't seen issues with it... Primarily because I never use OVR :) Do you have a screenshot handy we can include to verify when it's broken?

[mackenza]

on the screenshots, the current max-width of the stylesheet we are using is 739px so if we want a 16:9 aspect ratio, that means a height of 415px. So lets make it that the standard for a screenshot is 739x415px. Yes?

Also, I recommend bumping your font to something like 14px so the text is more readable and people can see the colors better. We should not have shadows on the screenshots. Perhaps someone with CSS skills can modify the site css to add a shadow on the screenshot containers?

[larz0]

@MiguelCastillo if it looks the same as the normal cursor then it's broken. It should either be an underline or a block (char background). For some reason if the theme is not 'dark' then it'd show both the left border and bottom border that can't be overwritten with theme.css, probably due to some CSS specificity thing.

[MiguelCastillo]

@larz interesting. Now it rings a bell from a long time ago

[wormeyman]

@mackenza I vote for at least a 720p photo, that will give us more room for future expansion. Also if we wanted to we could use the high res photos and scale them down for hidpi devices.

[Denisov21]

@mackenza I vote for at least a 720p photo!

[marcelgerber]

We should make sure the active find highlight (current match) and the general find highlight (other matches) are different. I saw some themes where they weren't.

Btw, I updated the description to mention themes.json.

[mackenza]

I think we need to get the word out more about Brackets Themes. Since we have in our workflow to add your theme to the themes.json file when it gets published to the registry, perhaps we can also have a standard line in our package.json files like:

<actual description text>. See how this theme looks on http://brackets-themes.github.io

or something like that. I don't think the registry supports links so it would just be text.

[larz0]

@mackenza can't wait for the themes tab in the extension manager :heart_eyes:

[MiguelCastillo]

@mackenza +1 for the standard line!

@larz0 +1 for the themes' tab in the extension manager! Whoever is creating it needs to get that shit done already :D

[larz0]

@MiguelCastillo no rush! (WOULD BE GREAT FOR SPRINT 43 THOUGH.)

[mackenza]

I hope they don't give it to that new core contributor, too important for a n00b rookie... oh wait, wasn't that you @MiguelCastillo ? :sunglasses:

[MiguelCastillo]

hahaha, you know it, @mackenza !