Brad-Davidson / MealPlanner

0 stars 1 forks source link

Josh's Code review 1 suggestions #27

Open JoshuaGyau opened 3 years ago

JoshuaGyau commented 3 years ago

Analysis of the program. I like the idea, this is an app that I would personally use. the UI looks simple and effective. they still have a lot to complete but, they have a great foundation already set up

Was the program available in UC Github on time? yes the program was available on time

Is the program documented/commented well enough for you to understand? yes. the program is documented very well.

Does the program compile? it was able to compile.

Rationale behind your changes.

Since a lot of the changes had already been mentioned in previous code reviews, I avoided repeating them. I did some formatting to make the code to look cleaner, like I removing some commented code that was no longer necessary. also made a lot of small changes that make the code more readable and cleaner. I also added a few technical suggestions as well. like changing some of there concatenated strings into string laterals. that was one of the things i learn while doing this code review.

What I learned.

  1. while researching the best practices for kotlin, I ran into string laterals and decided to incorporate it into their code.
  2. by reviewing their code, I learned more about how to display data on the UI side, which will be very helpful with my project.
  3. by reviewing their code, I also learned from how they used queries to grab their data.
discospiff commented 3 years ago

You probably don't need to merge this one because: 1) Formatting can be done automatically by IDE. 2) Some non-formatting changes in here, but they have been suggested in prior reviews.