search

Brad-Davidson / MealPlanner

0 stars 1 forks source link

My code review Suggestions #28

Closed jPraiser23 closed 3 years ago

jPraiser23 commented 3 years ago

Analysis: The Project works so far and there a few parts that aren't quite working. The few parts that aren't working must be planned for the future. Mainly the unit tests aren't working. The app builds with the UI provided which gives a general idea of what the app is planned to do. Retrieving reciepes for meals.

Technical Suggestions: 1) Use Nav graph to go from one fragment to another. 2) MealPlanService should be updated to work with json call 3)MealPlanUnitTest and RecipeUnitTests should be updated to run the test smoothly (It could be the issue with Json Call, so maybe create mock data for testing until the json call is updated

Technical Concepts: 1)Applying a Nav Graph will make it easier to add new fragments/activities for the UI Navigation Tutorial: https://www.youtube.com/watch?v=885STaxx_So&ab_channel=CodinginFlow Docs: https://developer.android.com/guide/navigation/navigation-getting-started 2)Getting Data with LiveData Tutorial/Docs: https://developer.android.com/codelabs/kotlin-android-training-internet-data#2 3)Local Database (If you guys decide on saving data locally.) Docs: https://developer.android.com/training/data-storage/room

discospiff commented 3 years ago

I don't recommend a merge of this branch. -Formatting can be handled automatically by the IDE. No need for a separate branch. -Several of the suggestions in this review were covered in other reviews. In those cases, first one in wins. See those reviews for merge comments. -Conversation does not belong in source code comments.