Brad-Davidson / MealPlanner

0 stars 1 forks source link

Code Review 2 changes #38

Closed JoshuaGyau closed 3 years ago

JoshuaGyau commented 3 years ago

https://kotlinlang.org/docs/visibility-modifiers.html#packages I learned about the internal visibility modifier. I saw it used for the first time in their code, even though it was not needed in that instance.

they have a search Icon that displays the textbox after it is clicked. I like that idea a lot, and will be adding something similar to my project.

I also learned how to change the fragment by looking at how they change to the details fragment whenever a recipe is selected. this is something I have recently been working on for my project so it was very helpful.

discospiff commented 3 years ago

These changes reduce technical debt. It is worth merging, or implementing specific changes manually. (Organize imports can be done automatically by IDE.)

Brad-Davidson commented 3 years ago

I'm merging this branch because it seems to reduce the amount of unneeded importants. The code for the "save" function was commented out for testing stuff, but it seems as we may be going in a new direction anyways. Thanks for the code review!