Closed JoshuaGyau closed 3 years ago
These changes reduce technical debt. It is worth merging, or implementing specific changes manually. (Organize imports can be done automatically by IDE.)
I'm merging this branch because it seems to reduce the amount of unneeded importants. The code for the "save" function was commented out for testing stuff, but it seems as we may be going in a new direction anyways. Thanks for the code review!
Analysis of the program. Their project is looking good so far. their UI just needs to be organized and little better. the placement of the icons, the spacing and little things like that. but overall, the project is coming together very nicely
Was the program available in UC Github on time? Yes it was available on time
Is the program easy for you, as an outsider, to understand? yes, they left a lot of comments, used good naming conventions. the readme was clear, the requirements made sense. the whole projects was simple to follow.
Does the program compile? yes the program compiles
Rationale Behind Changes I removed unused imports I removed commented code that is no longer necessary changed some of the variables to camel case changed the visibility modifiers for a some variables and methods.
What I learnt
https://kotlinlang.org/docs/visibility-modifiers.html#packages I learned about the internal visibility modifier. I saw it used for the first time in their code, even though it was not needed in that instance.
they have a search Icon that displays the textbox after it is clicked. I like that idea a lot, and will be adding something similar to my project.
I also learned how to change the fragment by looking at how they change to the details fragment whenever a recipe is selected. this is something I have recently been working on for my project so it was very helpful.