search

BradGreig / Hybrid21CM

1 stars 3 forks source link

z_step_factor and z_heat_max #12

Closed steven-murray closed 5 years ago

steven-murray commented 5 years ago

At the moment, both of these parameters have "convenient" python incarnations in various functions, so that the user doesn't have to interact with the global params. In these functions then, the global_params have to be kept consistent, which is a bit of bookwork (it seems to be working at the moment).

In some way, it may just be better to leave these purely as global_params, which the user can set directly if they want to change stuff. They can be accessed easily from Python anyway. This way there is only one place to find their value, so it is always consistent.

The only thing really blocking this from happening is that currently the z_step_factor in Python can also have a value of None, which basically just means "I don't care that this box is not above Z_HEAT_MAX, just treat it like it is!" The idea is that this would be a convenient way to generate a spin_temp box, for example, directly at a given redshift without any evolution. However, I don't know how useful this "feature" is, and whether it's worth keeping around. Plus, I guess this could be done manually by setting Z_HEAT_MAX < redshift.

steven-murray commented 5 years ago

Moved to referenced issue.