search

BradGreig / Hybrid21CM

1 stars 3 forks source link

Include z_step_factor and z_heat_max as input parameters? #4

Closed steven-murray closed 5 years ago

steven-murray commented 5 years ago

I'm wondering if z_heat_max and z_step_factor should be input parameters that are part of defining whether a given data-set is compatible. As in, whether it should be read in from cache. I think probably they should, because you'd expect them to give slightly different answers (depending on how different they are).

steven-murray commented 5 years ago

Thinking about it a bit, the Z_HEAT_MAX parameter really should not be a global variable, as we allow simple access to change it within functions. It should rather be in the AstroParams struct. What do you think?

steven-murray commented 5 years ago

As of now, z_heat_max is definitely checked to make sure it is consistent. However, z_step_factor is not (since it doesn't convert to anything in the C code).

steven-murray commented 5 years ago

Fixed in e2c46a8e92d339e9d13ec1568ccf6095a0bc283a by making ZPRIME_STEP_FACTOR in global params always be consistent with passed z_step_factor