search

BradLarson / GPUImage

An open source iOS framework for GPU-based image and video processing
http://www.sunsetlakesoftware.com/2012/02/12/introducing-gpuimage-framework
BSD 3-Clause "New" or "Revised" License
20.22k stars 4.61k forks source link

Some filters not working on live video file filtering #1242

Open oltis opened 10 years ago

oltis commented 10 years ago

Hi,

We use this framework in our app for filtering some videos from disk while those videos are previewed on the screen (using GPUImageMovie and GPUImageView for this). We also allow live switching of filters while in this "preview" screen (we implemented the solution from here: https://github.com/BradLarson/GPUImage/issues/1178 for accomplishing this).

The issue is that some filters (GPUImageGrayscaleFilter, GPUImageSketchFilter and GPUImageSobelEdgeDetectionFilter) freeze one frame of the video in GPUImageView when applied. I made some quick changes in showcase demo to use a video file from disk instead of live camera feed and was able to reproduce the bug there also (there it displays a black or white screen instead of freezing on a frame but I guess it is the same issue).

Can someone help us with this?

PS: Thanks for this great framework.

oltis commented 10 years ago

Adding here the modified version of showcase demo I was talking above: https://dl.dropboxusercontent.com/u/3811052/FilterShowcase.zip

jmiller2 commented 10 years ago

I noticed this also with the GrayscaleFilter Issue #1241 . The filter is definitely getting called on each frame but somehow is not getting the correct texture to process.

schwarrrtz commented 10 years ago

i also implemented the fix from #1178 and see the same error when using sobel and sketch. the movie freezes on one frame.