search

BradLarson / GPUImage2

GPUImage 2 is a BSD-licensed Swift framework for GPU-accelerated video and image processing.
BSD 3-Clause "New" or "Revised" License
4.85k stars 605 forks source link

Conversion To Swift 4 Problems #206

Open EriFisher opened 6 years ago

EriFisher commented 6 years ago

I converted the code to Swift 4. The movies playback fine using GPUImage even with filters, however the camera is not working. I wonder if anyone would mind reviewing the changes and see if they can fix the camera bug themselves because I am a bit confused why it does not work. https://www.dropbox.com/s/uurrzf4xy47yae8/GPUImage.xcodeproj.zip?dl=0

andrewcampoli commented 6 years ago

You probably missed the naming change made to the sample buffer output method in AVCaptureVideoDataOutputSampleBufferDelegate.

It went from: func captureOutput(_ captureOutput:AVCaptureOutput!, didOutputSampleBuffer sampleBuffer:CMSampleBuffer!, from connection:AVCaptureConnection!) to: func captureOutput(_ output: AVCaptureOutput, didOutput sampleBuffer: CMSampleBuffer, from connection: AVCaptureConnection)

EriFisher commented 6 years ago

Thank you very much!

andrewcampoli commented 6 years ago

@SoundandStuff You're welcome! If you'd like to see this get onto master it may speed things up if you weigh in on my pull request: #212.