BradLarson / GPUImage3

GPUImage 3 is a BSD-licensed Swift framework for GPU-accelerated video and image processing using Metal.
BSD 3-Clause "New" or "Revised" License
2.68k stars 331 forks source link

GPUImage 3 has no MovieOutput? #44

Closed CharlyPico closed 4 years ago

CharlyPico commented 5 years ago

Hi there, I've been using GPUImage 2 for a while and realized that this GPUImage 3 version contains no MovieOutput yet, will there be an implementation for this soon?

I would love to upgrade my App to GPUImage 3, but MovieOutput is critical for my App.

Thanks! PD: Awesome work you are doing here, I love it.

Maxim-Appicstars commented 5 years ago

Hi there, seems to I face with the same issue: I need to save rendered video to file. @BradLarson, @RedQueenCoder Do GPUImage has functionality to save rendered video? And thank you for awesome work!

BradLarson commented 4 years ago

As of commit https://github.com/BradLarson/GPUImage3/commit/4172241e8ca055318bff5703bfba62b7bf8b7cdc , this has now been added. It may require some performance testing and more thorough evaluation, but it appears to work within test applications brought over from GPUImage 2.

hoangdado commented 4 years ago

Hi @BradLarson, thanks for your working, I have tried to run SimpleVideoRecorder example but got the error "Value of type 'Camera?' has no member 'audioEncodingTarget". If I comment out two line of code in ViewController.swift camera.audioEncodingTarget = movieOutput and self.camera.audioEncodingTarget = nilit works but the output video contains corruption (look like glitch effect). Hopefully you will fix it soon. PS: I using Iphone 7 Plus, iOS 12.3.1

Maxim-Appicstars commented 4 years ago

thank you @BradLarson