is there something wrong in setsat function in BlendShaderTypes.metal ?

BradLarson / GPUImage3

GPUImage 3 is a BSD-licensed Swift framework for GPU-accelerated video and image processing using Metal.

BSD 3-Clause "New" or "Revised" License

2.68k stars 331 forks source link

is there something wrong in setsat function in BlendShaderTypes.metal ? #64

Closed AddIcechan closed 4 years ago

AddIcechan commented 4 years ago

I found this code in setsat function in BlendShaderTypes.metal . /* b is max, r is mid, g is min */ c.r = mid(c.g, c.r, c.b, s); c.b = s; c.r = 0.0h;

is it should be like this ？ /* b is max, r is mid, g is min */ c.r = mid(c.g, c.r, c.b, s); c.b = s; c.g = 0.0h; 😂

RedQueenCoder commented 4 years ago

Lol. I changed it and I'm blaming the guy who was here before me. Thanks! 🙃

AddIcechan commented 4 years ago

Lol. I changed it and I'm blaming the guy who was here before me. Thanks! 🙃

it also exist in GPUImage2