search

BradenM / micropy-cli

Micropython Project Management Tool with VSCode support, Linting, Intellisense, Dependency Management, and more!
https://micropy-cli.readthedocs.io
MIT License
313 stars 25 forks source link

Unmantained Pyminifier breaks on SetupTools >=58 #279

Closed robertoetcheverryr closed 2 years ago

robertoetcheverryr commented 2 years ago

Hi! I've started down the road of MicroPython and stumbled upon this magnificent project. It's just what I wanted, since I moved from the Arduino IDE to a complete IDE like PyCharm, to have the advanced features since not having code completion was really irking me. I'm trying to make a complete guide on how to use lv_micropython from 0, including having a complete IDE that actually works, so this project was the last part of my journey (since I saw that some lv bindings still don't get updated automatically).

Now, when attempting to build the stubs from my already deployed firmware, I was asked to install the dependencies, and all but one was installed correctly. Pyminifier uses "use_2to3" which is currently failing in SetupTools 58 (I guess, due to Python2 being finally deprecated) and since it seems to have been left unmaintained I don't believe raising the issue over there would help. So, should an alternative to Pyminifier be found? should there be a requirement to keep SetupTools <58 for the time being? Thanks in advance

Josverl commented 2 years ago

I have updated micropython-stubber and process.py to use python-minifier which appears to work well. It produces even more compact code, and I have needed to adjust a number of tests.

if micropi-cli updates to use micropython-stubber v1.4.1 and update the dependencies, your existing code should work, or rather than running the minification on demand you could just pick up the minified version from micropython-stubber/minified

robertoetcheverryr commented 2 years ago

Thank you!

Josverl commented 2 years ago

@robertoetcheverryr , you may want to leave this open as @BradenM will still need to make a few changes to micropy-cli to integrate my changes

robertoetcheverryr commented 2 years ago

Reopened as per Josverl's comment

BradenM commented 2 years ago

@robertoetcheverryr Thank you for the report. I've (finally :grimacing:) found the time to look into this and am dealing with it now.

@Josverl Thanks for finding a solution. Working on updating everything now.