search

BradleyCai / ucr-schedule-visualizer

Generates an hour by hour view and shows the locations of all the classes from a raw class list from GROWL.
https://waa.ai/ucrsv
MIT License
5 stars 2 forks source link

Regexes don't capture certain course times #55

Closed BradleyCai closed 9 years ago

BradleyCai commented 9 years ago

Courses with different times for different days are not represented correctly.

For example: COE: LEARNING CENTER WORKSHOP
ARC -080 -018 NG 0.00 W 1110AM-1200PM
M 1110AM-0100PM
 Produces this: image

Regex and CourseParser.js should be updated and to fix this issue.

emmiegit commented 9 years ago

I think this is an issue with how the JavaScript uses the regular expressions. In my testing, the second regular expression (for 'sessions') caputured a list of all date/times just fine.

BradleyCai commented 9 years ago

Fixed in commit 2e51218

image

It was a problem with the regex. I changed the noncap session regex to be inside of a capture group so it now detects all instances of multiple sessions