search

BradnerLab / pipeline

bradner lab computation pipeline scripts
Other
53 stars 47 forks source link

bamliquidator_batch now compatible with latest bokeh version #51

Closed jdimatteo closed 9 years ago

jdimatteo commented 9 years ago

bamliquidator_batch was originally developed for bokeh 0.4. latest version is 0.9 and has some breaking changes. for a while we held off upgrading due to some performance problems with bokeh 0.5, but latest version has good performance and 0.4 is too old to keep trying to use.

resolves #26 fixes one of the errors in #49

jdimatteo commented 9 years ago

@bradnerComputation / Charles: can you please go ahead and merge this? I updated the version of the plotting library bamliquidator uses because the prior targeted version was getting pretty old. If a user has an incompatible version of the library, a warning message is logged and plotting is skipped.

I don't intend to publish an updated ppa at this time since this is a relatively small change.

charlesylin commented 9 years ago

Sure. Is there a merge request? Or should I do it

-Charles

On Sep 11, 2015, at 12:32 AM, John DiMatteo notifications@github.com wrote:

@bradnerComputation / Charles: can you please go ahead and merge this? I updated the version of the plotting library bamliquidator uses because the prior targeted version was getting pretty old. If a user has an incompatible version of the library, a warning message is logged and plotting is skipped.

I don't intend to publish an updated ppa at this time since this is a relatively small change.

— Reply to this email directly or view it on GitHub.

jdimatteo commented 9 years ago

https://github.com/BradnerLab/pipeline/pull/51

On Thursday, September 10, 2015, bradnerComputation < notifications@github.com> wrote:

Sure. Is there a merge request? Or should I do it

-Charles

On Sep 11, 2015, at 12:32 AM, John DiMatteo <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

@bradnerComputation / Charles: can you please go ahead and merge this? I updated the version of the plotting library bamliquidator uses because the prior targeted version was getting pretty old. If a user has an incompatible version of the library, a warning message is logged and plotting is skipped.

I don't intend to publish an updated ppa at this time since this is a relatively small change.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/BradnerLab/pipeline/pull/51#issuecomment-139451563.

John's business hour MST availability https://www.google.com/calendar/embed?src=john.dimatteo@ansys.com&ctz=America/Denver (and John's availability in EST https://www.google.com/calendar/embed?src=john.dimatteo@ansys.com&ctz=America/New_York )