BradnerLab / pipeline

bradner lab computation pipeline scripts
Other
53 stars 47 forks source link

Wrong binsize calculation accumulates offset errors with increasing bin numbers #69

Open Drmirdeep opened 5 years ago

Drmirdeep commented 5 years ago

There is a crucial bug in the binsize calculation in the bamliquidator.cpp file. Since the tool needs a gff file as input the length of a region is "end-start+1" and not "end-start" as in bed format. When demanding 60 bins for a region you get an offset of 60bp for the 60th bin already and thus miss the very end of your region. Further, a regions end position would then be start+binsize-1 if you stick with the gff format. However, I did not check the rest of the code. If it uses half-open intervals start+binsize would be correct of course.