BradyBrenot / huestacean

Philips Hue control app for desktop with screen syncing. C++ with Qt Quick GUI.
http://huestacean.com
Apache License 2.0
566 stars 54 forks source link

Windows 7 support #73

Open BradyBrenot opened 6 years ago

BradyBrenot commented 6 years ago

I'm not going to work on this myself. Too many platforms as-is, and I don't have any Windows 7 computers around home to test with. Even my 11-year-old Macbook Pro took the free Windows 10 upgrade just fine, even without Apple's support...


It looks like I might have hosed my screen_capture_lite fork's GDI support, or it was hosed upstream, or I'm doing something bad in huestacean that's not letting it work. Getting reports that screen capture on Windows 7 just doesn't work.

EDIT: It's upstream in screen_capture_lite, see below.

Collisionc commented 6 years ago

I'll load it up on my windows 7 laptop and run it through debug, if it's something simple/obvious I'll PR it.

smasherprog commented 6 years ago

I am the writer of the screen capture library and I used to have support for windows 7 but dropped it since I just dont have any windows 7 machines to test on any more. The code can brought back into the repo, but I dont have time to maintain it unfortunately. Also Microsoft is going to end support for win7 jan 2020 which is 1.5 years from now so that also added to my decision.

Collisionc commented 6 years ago

So I spent an hour setting up VS2017/qt/etc on the laptop, loaded up the debugger and put some break points in, attached to the debuggable program and found out that the stupid thing works without any issues on windows 7 -- at least on my laptop.

I should have just loaded up the release version first :P

The laptop doesn't have switchable graphics, and it is relatively modern hardware -- 6th gen skylake. Unfortunately, it only has mini-displayport out and I don't have any adapters to hook it up to a TV and see if maybe that is causing an issue on windows 7, as I'm sure a lot of people are trying to watch movies on the tv with their laptops hooked up via hdmi.

I'll see about getting a mini-dp --> hdmi adapter and trying that out sometime this week. My stab in the dark guess is that windows 7 doesn't see the hdmi --> tv connection like windows 10 would, and thus doesn't show up as a monitor to sync to. It also could potentially be an issue that updating the bios on the laptop will fix.

Collisionc commented 6 years ago

Yeah even when using various settings for displaying to the TV I'm able to sync Win7, so it must be older-hardware related.

smasherprog commented 6 years ago

I always thought that it should work, but never had any time to test. Coool

Working on the mac update now. for the library.It should be done today

BradyBrenot commented 6 years ago

Cool. I might be a bit delayed pulling that in but when I do I'll let you know if I have any problems.

On Sat, Apr 14, 2018, 10:15 Scott, notifications@github.com wrote:

I always thought that it should work, but never had any time to test. Coool

Working on the mac update now. for the library.It should be done today

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BradyBrenot/huestacean/issues/73#issuecomment-381332157, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmoWGCYMHBzctp7lyqwHDSk0o50pVGqks5togSBgaJpZM4TLTAG .

smasherprog commented 6 years ago

I got most of the mac code in place, but I found areas for code improvement so I am rolling that info this as well. It will take a few more days.. The public api will be the same, but internally, things will be cleaner.