Braekpo1nt / MCTManager

The Paper plugin for Minecraft Tournament (MCT)
Other
1 stars 1 forks source link

FakePlayerDeathEvent should not use fake event caller #574

Open Braekpo1nt opened 3 months ago

Braekpo1nt commented 3 months ago

Description

Simply call the appropriate death logic rather than using Bukkit.getServer().callEvent().

This is related to #522, because this can be done during that restructure.

Reason for Redesign

The constructors for PlayerDeathEvent are marked as @APIStatus.Internal, meaning they are meant only to be used internally in the API, not directly by me. Also, the calling of the event simply results in extra filtering and an unnecessary cancelling of the event.

Definition of Done

Related Issues