search

Brain-up / brn

The idea of this project is to design and make a web-application (with scientist cooperation) which would contained series of special audio trainings to support people with central auditory skills deficit to allow them to train them to listen better.
https://brainup.site
Creative Commons Zero v1.0 Universal
59 stars 26 forks source link

#2406 Add lastVisit field and set it when user logs in #2527

Closed naXa777 closed 10 months ago

naXa777 commented 10 months ago

Closes #2406 "Add lastVisit field and set it when user logs in"

Changes description:

ElenaSpb commented 10 months ago

could you please join our dev chat https://t.me/+R-6ThlxgP5QyZmMy

ElenaSpb commented 10 months ago

also

  1. from task we have "current value from Last Visit move to field lastStudyActivity" do you want to implement it too?

  2. I think it would be logically to set lastVisit in case null - the registration date. it can not be null

naXa777 commented 10 months ago

I think it would be logically to set lastVisit in case null - the registration date. it can not be null

Done.

naXa777 commented 10 months ago

"current value from Last Visit move to field lastStudyActivity" do you want to implement it too?

~yes, but I don't see "Last Visit" field anywhere in code. There was no Last Visit field before, or maybe it was removed recently, IDK. @ElenaSpb, please clarify this requirement.~

UPD: yes, I see lastDone field. Let me implement the change.

naXa777 commented 10 months ago

some checks have failed. and I suspect that they are broken, cause it's not related to the changes in PR #2527.

I kindly ask to merge this PR and fix the failing GitHub actions separately:

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here

ElenaSpb commented 10 months ago

Thank you for contribution to our project!