search

BrainBlend-AI / atomic-agents

Building AI agents, atomically
MIT License
1.05k stars 85 forks source link

added delete by turn id #23

Closed mickyarun closed 2 weeks ago

mickyarun commented 2 weeks ago

Agent Memory Added a new proc to delete by turn id When using search tool , we add search as system message to memory and there is no way to delete only this turn id for next conversion, so added method called delete_turn_id by passing turn_id we can delete the particular message from memory

Added all the conditions like empty memory, last message , invalid turn id

KennyVaneetvelde commented 2 weeks ago

Great addition!

mickyarun commented 2 weeks ago

change self.current_turn_id = max(msg.turn_id for msg in self.history) to self.current_turn_id = self.history[-1].turn_id @KennyVaneetvelde which was wrong in earlier commit

KennyVaneetvelde commented 2 weeks ago

Alrighty @mickyarun I left some comments - once those are fixed & the tests are updated I can approve & merge!

mickyarun commented 2 weeks ago

Alrighty @mickyarun I left some comments - once those are fixed & the tests are updated I can approve & merge!

@KennyVaneetvelde I can't find any comments in the PR, have you submitted?

KennyVaneetvelde commented 2 weeks ago

@mickyarun Woops, I in fact had not submitted! 🙄 My bad!

mickyarun commented 2 weeks ago

@KennyVaneetvelde I have resolved all the comments