Optimize max pool - Githubissues

BrainJS / brain.js

🤖 GPU accelerated Neural networks in JavaScript for Browsers and Node.js

https://brain.js.org

MIT License

14.25k stars 1.06k forks source link

Optimize max pool #887

Closed ddsol closed 1 year ago

ddsol commented 1 year ago

Optimize the max pool and compare and fix tests Also: Fix some spelling and linting and some type issues

Description

Optimize the bounds of the pool operation, in particular the compare step. Also some issues with types were fixed and minor cleanup.

How Has This Been Tested?

Tests for the pool have been updated and fixed

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

[x] My code focuses on the main motivation and avoids scope creep.
[x] My code passes current tests and adds new tests where possible.
[x] My code is SOLID and DRY.
[x] I have updated the documentation as needed.

Reviewer's Checklist:

[ ] I kept my comments to the author positive, specific, and productive.
[ ] I tested the code and didn't find any new problems.
[ ] I think the motivation is good for the project.
[ ] I think the code works to satisfies the motivation.