Closed sarthakpati closed 7 months ago
/format
:robot: I will now format your code with black. Check the status here.
I am pretty sure there is a better way to do this (for example, having a base
Config
class underereg.configurations
that reads thesample_config.yaml
and populates a baselineConfig
object, which can then be used in theRegistrationClass
class.However, I unfortunately don't have the kind of time on hand right now to make this change. I would really appreciate it if someone could help me put this together.
can you open a feature request so we don't lose track of this? @sarthakpati
@sarthakpati currently, unit tests are not passing yet.
once this passes unit tests and is merged, we can merge https://github.com/BrainLesion/eReg/pull/57 to require passed tests before merging, so we don't break ereg again :)
How do you feel about putting default values in a yaml file to create a single source of truth?
Sure, but let's tie it in with #60. Doing yaml I/O in a purely computational class is just clunky.
I am pretty sure there is a better way to do this (for example, having a base
Config
class underereg.configurations
that reads thesample_config.yaml
and populates a baselineConfig
object, which can then be used in theRegistrationClass
class.However, I unfortunately don't have the kind of time on hand right now to make this change. I would really appreciate it if someone could help me put this together.
Includes #57, so that should/will get merged along with this.