search

BrainSlugs83 / NewBiospheresMod

An update of Risugami's old Biospheres Mod for Minecraft. To avoid confusion, I've named it the *New* Biospheres Mod. :-)
Other
9 stars 8 forks source link

Structures, Mines, and Caves, etc. don't generate correctly. #6

Open BrainSlugs83 opened 9 years ago

BrainSlugs83 commented 9 years ago

Make the structure generation stuff work -- that is, populate the domes with towns, and the undergrounds with caves, rivers, and abandoned mine shafts and other naturally occurring terrain/features, etc. (this is an issue with the original mod as well).

BrainSlugs83 commented 9 years ago

Also, it would be awesome if the lake and terrain generation (etc.) were handled by the biome (so no hard coded spherical lakes, etc.)

TheLoneWolfling commented 9 years ago

This is currently the single biggest issue with this mod - large chunks of the game are unavailable due to lack of spawners / end portal / villages etc.

Some of these can be worked around, but not all of it.

BrainSlugs83 commented 9 years ago

Agreed on importance. Can you give an example of the workarounds that you are referring to?

TheLoneWolfling commented 9 years ago

Sure. For example: You can work around the lack of spawners by building a standard hostile mob trap instead (or go to the nether). Not as efficient, but meh. And it's relatively easy to light up enough to make them fast. You can work around the lack of villages by turning zombie villagers. You can work around the lack of glowstone (if the nether isn't enabled) by killing witches (as they do spawn as hostile mobs, albeit rarely.) or trading. You can get music disks by killing creepers with skeletons. You can get name tags by fishing or trading. You can get saddles and melons by trading.

Much the same sort of workarounds that you end up doing in a superflat world.

Unfortunately, there are a number of things that plain cannot be worked around. For example:

BrainSlugs83 commented 9 years ago

Interesting.

Yes, hopefully we'll be able to do normal structure generation and such soon.

I'm confused about the "nether not enabled" comments, because -- I don't think there's a way to disable the nether (or was this added in 1.8? or am I missing something?) -- the "Nether" seemed to work for me when I tested it. -- I thought it was "The End" that was broken?

Another workaround for glowstone (or missing blocks) is to put them as part of the bridges, etc. (Glowstone makes for okay bridge rails).

TheLoneWolfling commented 9 years ago

It's only with a dedicated server: allow-nether=false in server properties.

It's something I tend to enable because the nether doesn't really fit the whole biospheres / skyblock thing. Especially not with the nether biospheres.

And I'm not sure how one would fit in lilypads / packed ice as bridge rails.

debrechtabel commented 9 years ago

@BrainSlugs83 If you're ok with it, I'll start bringing over the changes from my fork that do actual terrain generation. Structures and caves are fully supported already.

Edit: this would also probably fix issues 4, 5, 13, and 14.

TheLoneWolfling commented 9 years ago

@trevordebrecht Go ahead and make a pull request. Worse comes to worse, BrainSlugs says no.

Are the structures and caves configurable? Specifically, can cave generation be toggled on / off?

BrainSlugs83 commented 9 years ago

@trevordebrecht, yes, please do! -- Keep in mind, I'm still targeting 1.7.x, and I think there's been a bit of refactoring and changes to my branch since you originally forked. (I plan to do future refactoring to try and target other frameworks as well. -- I will probably move the forge specific stuff into it's own package/namespace.)

The things that you've already fixed that I still need to fix, I am basing off your code where I can.

For example, the spawning fix I made was based on your work, but heavily adapted (some bugs came out of that that I'll need to fix, but, the idea was that it wouldn't be limited to just glass; also I left the WorldProvider registered, albeit immensely simplified -- simply to prevent spawning in the void, which seemed to still be a problem in 1.7).