BrainardLab / OneLightToolbox

Brainard Lab code for talking to our OneLight boxes
MIT License
1 stars 0 forks source link

Harmonize photoreceptor classes in SST #2

Closed spitschan closed 7 years ago

spitschan commented 7 years ago

I recently updated the function GetHumanPhotoreceptorSS in the SilentSubstitutionToolbox to resolve various unsupported and outdated spectral sensitivity types. The function OLEstimateConePhotopigmentFractionBleached called for the cone types LCone, MCone, SCone, LConeHemo, MConeHemo, and SConeHemo. These, which were constructed from the Stockman-Sharpe nomograms, are now legacy functions in the GetHumanPhotoreceptorSS as we believe that the ones constructed from tabulated absorbances ({L, M, S}ConeTabulatedAbsorbance and {L|M|S}ConeTabulatedAbsorbancePenumbral) do a better job.

I've therefore removed any references to the old nomogram-constructed cone fundamentals, and use the tabulated ones. It is worth noting that the fraction pigment bleached will likely be different between the two spectral sensitivities, but these differences are directly related to how well the nomogram spectral sensitivities fit the tabulated ones.

DavidBrainard commented 7 years ago

This looks good.