search

Brainhack-Donostia / ica-aroma-org

Repository to prepare the ICA-AROMA tutorial for Brainhack Donostia.
Apache License 2.0
1 stars 3 forks source link

Should motion parameters be squared? #28

Closed tsalo closed 4 years ago

tsalo commented 4 years ago

Summary

ICA-AROMA removed the step where motion parameters were squared (but kept the comment about squaring them) in https://github.com/maartenmennes/ICA-AROMA/commit/7b000665b45ea49b749bfe89be065f50f4921523#diff-5f3554c3cc435b1caa80a92f299d6728e62963ec1b378dd4030b39da254300aaL235. I assumed that this was a mistake, so I added it back in (see below):

https://github.com/Brainhack-Donostia/ica-aroma-org/blob/4f6b91b6d83e25b129872ccb8064e10fbf50cf48/aroma/features.py#L50-L52

I'm not sure if that is actually the right thing to do, though, based on the official code and this:

https://github.com/Brainhack-Donostia/ica-aroma-org/blob/4f6b91b6d83e25b129872ccb8064e10fbf50cf48/aroma/features.py#L80-L86