search

Brainhack-Donostia / ica-aroma-org

Repository to prepare the ICA-AROMA tutorial for Brainhack Donostia.
Apache License 2.0
1 stars 3 forks source link

Enh/snake case #38

Closed eurunuela closed 4 years ago

eurunuela commented 4 years ago

Closes #27 .

Changes proposed in this pull request:

I hope I didn't miss any 🤞

tsalo commented 4 years ago

This looks great, thank you. The dest variables in the CLI will need to be updated as well though. Also, could you do the features file too?

eurunuela commented 4 years ago

Thought I added the features file to the commit. Sorry about that. Will commit now.

eurunuela commented 4 years ago

I think that should make it.

tsalo commented 4 years ago

The CLI target variables still need to be updated. Instead of the normal FSLDIR error, the integration test is failing on the following:

TypeError: aroma_workflow() got an unexpected keyword argument 'denType'

eurunuela commented 4 years ago

That's weird. I did add the changes but for some reason, GitHub did not pick them up.

eurunuela commented 4 years ago

Okay, it should be fine now.

eurunuela commented 4 years ago

The core changes look good to me, but it looks like you're reintroducing some lines I changed in #32. I've flagged those lines with review comments.

Good catch, thank you!