search

Brainhack-Donostia / ica-aroma-org

Repository to prepare the ICA-AROMA tutorial for Brainhack Donostia.
Apache License 2.0
1 stars 3 forks source link

Add unit testing and continuous integration #5

Closed tsalo closed 4 years ago

tsalo commented 4 years ago

There are currently no tests in the ICA-AROMA code. We can add unit tests and continuous integration with CircleCI to ensure that we don't introduce any breaking changes. The good news is that, since we're working off of functional code, we can run ICA-AROMA on a test dataset to generate outputs, and then compare against those as our "ground truth."

eurunuela commented 4 years ago

Do we want to write an integration test with the original code?

I'm thinking it might be best to do the refactoring making sure the integration test passes on every refactoring PR.

tsalo commented 4 years ago

@eurunuela I know that you have added hardcoded values to the tests, but what do you think about adding actual outputs from ICA-AROMA (the original version)?

EDIT: There also seem to be issues in the makefile that are breaking the CI. Do you know how to deal with that?

eurunuela commented 4 years ago

Sure! That sounds great! I added hardcoded values mainly for the refactoring.

I'll have a look at the Makefile, thanks!

eurunuela commented 4 years ago

The Makefile was fine. I had to add a couple of options to setup.cfg. I've made them in #18