Add Windows implementations.

BrainiumLLC / cargo-mobile

Rust on mobile made easy!

Apache License 2.0

1.23k stars 52 forks source link

Add Windows implementations. #45

Open kazatsuyu opened 3 years ago

kazatsuyu commented 3 years ago

The following points should be noted:

cargo mobile update has not been tested, but it will probably fail on Windows because the running binary cannot be overwritten.
Use hard links for libraries under jniLibs since symbolic links cannot be created, and simply copy them if they fail.
Instead of symbolic links for assets directory, copy them at Gradle build time.

kazatsuyu commented 3 years ago

Can someone please review it?

zeerooth commented 3 years ago

oh god, I'm so sorry, I wanted to enable the windows CI on your branch, but I accidentally pushed some changes from my other branch, I'll try to have that sorted out

kazatsuyu commented 3 years ago

I think I've solved the problem of symbolic links.

In addition, I fixed a path problem in stable that I missed using nightly.

I've confirmed that the commands work on Windows except cargo update, but I haven't checked if there are no problems on Linux and macOS. (Of course, it would be better to have someone other than me test it on Windows as well.)

zeerooth commented 2 years ago

Once again, thank you so much for your contribution! I think that now this PR is ready to be merged - I've briefly tested the latest version on Linux and Mac, updated the README and approved it, but since the changes here are quite massive, I'd like someone else to take a look and approve as well.

@francesca64 may I kindly ask you to take a look?

amrbashir commented 2 years ago

If there is any work needed for this PR to be merged, I'd be glad to help (ofc, If the author of this PR gives me permissions to, or if he is inactive, I could create a new PR that is build on top of this PR and keep his commits in the new PR)