search

BrainsOnBoard / bob_robotics

Collection of code for interfacing with robot platforms + simulations and visualisation
GNU General Public License v2.0
2 stars 6 forks source link

Fix build on Windows #332

Closed alexdewar closed 2 years ago

alexdewar commented 2 years ago

I fear the range library may not work properly on MSVC :cry:

neworderofjamie commented 2 years ago

Do you want me to test? I have VS2019 on my machine at home which is supposed to be C++17 compliant

alexdewar commented 2 years ago

Thanks, but I have been trying it myself with VS2019 and it's not working :cry:. Even setting the C++ standard to C++17 doesn't fix it (although it does actually work with C++11 on gcc).

I should probably open an issue. I don't think I'm the only one having problems though: https://github.com/ericniebler/range-v3/issues?q=is%3Aissue+is%3Aopen+msvc

alexdewar commented 2 years ago

It's kinda weird really. I had it in mind the ranges-v3 library was a pretty standard one.

neworderofjamie commented 2 years ago

The docs say it needs:

/permissive- and either /std:c++latest or /std:c++17

alexdewar commented 2 years ago

I tried that and sadly it still didn't work. The source files for the lib appear to be littered with workarounds for MSVC -- I'm not sure what the issue is, because as you say, VS2019 should be standards-compliant.

I forget what the exact error messages are, but I might ask your help once I get round to firing up my Windows VM again.

alexdewar commented 2 years ago

Sorted!