search

BrainsOnBoard / bob_robotics

Collection of code for interfacing with robot platforms + simulations and visualisation
GNU General Public License v2.0
2 stars 6 forks source link

Roboclaw #333

Closed neworderofjamie closed 2 years ago

neworderofjamie commented 2 years ago

Fancy a last review of some code? I promise I made it extra fun by gratuitous use of variadic templates....

This is the code to drive the big new outdoor robot as a BoB robotics tank. I have only tested with a single motor connected to the motor controller so may push some fixes once we have the whole thing assembled. Also, as the Command enum indicates, you can do a lot more fancy stuff with this motor controller than I have currently implemented but the variadic template glory of readCommand and writeCommand should make it very easy.

neworderofjamie commented 2 years ago

The code definitely works on the robot - will fix the dubious retry logic and maybe we can merge tomorrow?

alexdewar commented 2 years ago

Sure!

⁣Sent from BlueMail

On 23 Jun 2022, 18:31, at 18:31, neworderofjamie @.***> wrote:

The code definitely works on the robot - will fix the dubious retry logic and maybe we can merge tomorrow?

-- Reply to this email directly or view it on GitHub: https://github.com/BrainsOnBoard/bob_robotics/pull/333#issuecomment-1164684202 You are receiving this because your review was requested.

Message ID: @.***>

alexdewar commented 2 years ago

Tagging @shepai so he's in the loop.