BrainsOnBoard / bob_robotics

Collection of code for interfacing with robot platforms + simulations and visualisation
GNU General Public License v2.0
2 stars 6 forks source link

Parallelism issues in ``MemoryBase::trainRoute`` #357

Closed neworderofjamie closed 8 months ago

neworderofjamie commented 9 months ago

The snapshot bot encapsulates a bunch of image preprocessing logic in ImageInput classes. These are not thread-safe e.g. m_Unwrapped at https://github.com/BrainsOnBoard/bob_robotics/blob/snapshot_bot_load_fix/projects/snapshot_bot/image_input.cc#L71 is reused to reduce runtime memory allocations. However, they were being applied during parallelized loading which caused very weird image corruption issues! Making these thread-safe would make this code very messy so I'm just running these serially.