search

Brainsware / puppet-trafficserver

Puppet module to manage trafficserver installation and configuration
https://forge.puppet.com/brainsware/trafficserver
Apache License 2.0
1 stars 7 forks source link

Update README.md #1

Closed dbollaer closed 11 years ago

dbollaer commented 11 years ago

rev_map instead of reverse_map

dbollaer commented 11 years ago

fix ssl concat

igalic commented 11 years ago

General commentary: you should take a look at how GitHub recommends collaborative workflow.

Also, there's two more instances of rev_map:

igalic@levix ~/src/bw/puppet-trafficserver (git)-[master] % ack 'rev_map'
manifests/config/remap.pp
44:#   rev_map => $reverse_map,
55:  $rev_map   = {},
igalic commented 11 years ago

Here's my tree with all your changes and my comments: https://github.com/Brainsware/puppet-trafficserver/tree/rev_map+ssl+concat - btw, you might also want to configure your git to set username/email

dbollaer commented 11 years ago

Thank you, I think you forgot to rename, I am still very new to augeas lenses.

set rev_map[.='<%= backend -%>'] <%= backend %> set rev_map[.='<%= url -%>']/replacement <%= url %>

igalic commented 11 years ago

Nope. Those come from the augeas Lens themselves, and I didn't want to touch that, as it maps exactly to the directive in Traffic Server. The only reason why I thought renaming it to rev_map would be a good idea was because rev_map is shorter.

igalic commented 11 years ago

If it's okay with you, I'll merge this branch of mine with your commits in it, and push out a new release.