search

Brainsware / puppet-trafficserver

Puppet module to manage trafficserver installation and configuration
https://forge.puppet.com/brainsware/trafficserver
Apache License 2.0
1 stars 7 forks source link

Create cache directory #15

Closed Titotix closed 10 years ago

Titotix commented 10 years ago

This pull request adds the creation of cache directory.

igalic commented 10 years ago

can you please squash down to one and and rebase them against our master branch, rather than merging it in?

Titotix commented 10 years ago

I discover squash and rebase and like it ! Does it fit your wish now ?

igalic commented 10 years ago

@Titotix even though I'm currently working on completely overhauling this code (#16) I'll happily accept your patch, but please fix the issues I pointed out above: even though the code base now is ugly and cluttered and not very puppet-like, I'd like to prevent it from becoming even more so ;)

igalic commented 10 years ago

one more notes, since you're just discovering git:

The Github workflow generally recommends to build every new feature / bugfix / etc… on a separate branch. That makes tracking / merging / rebasing it that much easier

Titotix commented 10 years ago

I didn't find keys function of stdlib so I looked for a work-around... It handles multi entry now, I tested it. You are right to be demanding ;)