search

BrakusTapus / KirboRotations

4 stars 0 forks source link

DRK Unmend #31

Open LTS-FFXIV opened 9 months ago

LTS-FFXIV commented 9 months ago

This line causes DRK to only ever use Unmend if bloodweapon is on cooldown or has 5 stacks

https://github.com/BrakusTapus/KirboRotations/blob/2d5e5a77b9717808e8b362bceea545a9678a1eb3/KirboRotations/Tank/DRK_Default.cs#L174C10-L174C10

Unsure why unmend is tied to bloodweapon but being tied like this is just bricking ranged actions

BrakusTapus commented 9 months ago

Cheers, for the feedback, the DRK rotation used in v1.0.0.21 was an older version of Archi's Default Rotation, which should've been exlcuded from the compiler but i mustve forgor, anyway in newer version of KirboRotation (current v1.0.0.23) a newer version of the DRK rotation should be available.

LTS-FFXIV commented 9 months ago

Line still in on new version, preventing unmend use

https://github.com/BrakusTapus/KirboRotations/blob/e67160d5ecadfbe7332cf9f7aceabd580cfec9d5/KirboRotations/PvE/Tank/DRK_Default.cs#L289C1-L289C114

line should just be
if (Unmend.CanUse(out act))

bloodweapon should have its own logic for use as basically a pseudo lucid dreaming and when Darkside is up due to darkside halting MP regeneration, XIVsloth has logic showing how it should be used

https://github.com/Nik-Potokar/XIVSlothCombo/blob/47b8f80df7765c729639ded303031e108d2b9476/XIVSlothCombo/Combos/PvE/DRK.cs#L111

and

https://github.com/Nik-Potokar/XIVSlothCombo/blob/47b8f80df7765c729639ded303031e108d2b9476/XIVSlothCombo/Combos/PvE/DRK.cs#L167C4-L167C4